Open
Conversation
Owner
|
Awesome, thanks for the patch! However, this is unsupported on older versions of libssh. The build hosts use 0.6.3, and I'd like to keep that version supported ideally. So please add a check in |
Permits preventing an indefinite hang when handing control to libssh. Added this for an issue unrelated to wsh: Older sshd instances might only support obselete MAC algorithms (e.g. hmac-sha1 or hmac-md5). If either the client or server doesn't support a particular HMAC, the behavior appears to be to block indefinitely... If the list is explicit about the supported algos, the connection (correctly) fails immediately. e.g. option usage: --ssh-opt "macs=hmac-sha2-256"
Author
|
Hey, look at that! Their header provides LIBSSH_VERSION_INT and SSH_VERSION_INT for us :) |
Owner
|
Your test is failing because of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Permits preventing an indefinite hang when handing control to libssh.
Added this for an issue unrelated to wsh: Older sshd instances might only
support obselete MAC algorithms (e.g. hmac-sha1 or hmac-md5). If either the
client or server doesn't support a particular HMAC, the behavior appears to be
to block indefinitely... If the list is explicit about the supported algos, the
connection (correctly) fails immediately.
e.g. option usage: --ssh-opt "macs=hmac-sha2-256"